From 7d66dcac87ebc86c8b66c6f90cc26feafc915a36 Mon Sep 17 00:00:00 2001 From: Gavin Nugent Date: Sat, 25 Apr 2026 13:52:55 +0100 Subject: [PATCH] install/uninstall: write windowrules to hyprland.conf MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Walker would launch NO-CODER fullscreen instead of floating because the windowrules block was written to ~/.config/hypr/windows.conf — a file Hyprland never sources. Omarchy's hyprland.conf only sources the *system* windows.conf under ~/.local/share/omarchy/default/hypr/, so any rules in a user-level windows.conf were silently ignored. Point HYPR_CONF at ~/.config/hypr/hyprland.conf instead. The marker-block append/strip logic stays the same and remains idempotent across re-runs. Co-Authored-By: Claude Opus 4.7 (1M context) --- install.sh | 9 ++++++++- uninstall.sh | 2 +- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/install.sh b/install.sh index 0826810..4489b17 100755 --- a/install.sh +++ b/install.sh @@ -22,7 +22,14 @@ BIN_DIR="$HOME/.local/bin" DESKTOP_DIR="$HOME/.local/share/applications" HICOLOR_DIR="$HOME/.local/share/icons/hicolor" INSTALL_DIR="$HOME/.local/share/nocoder" -HYPR_CONF="$HOME/.config/hypr/windows.conf" +# Append the windowrules block to hyprland.conf because that's the file +# Hyprland actually reads. Omarchy's `~/.config/hypr/hyprland.conf` sources +# its own defaults plus the user's `bindings.conf` / `monitors.conf` / etc., +# but it does NOT auto-source a `~/.config/hypr/windows.conf` — Omarchy's +# windows.conf lives under `~/.local/share/omarchy/default/hypr/windows.conf`, +# which we must not modify (it's overwritten by `omarchy-update`). Writing +# our rules to the user's hyprland.conf is the simplest, idempotent path. +HYPR_CONF="$HOME/.config/hypr/hyprland.conf" MARK_BEGIN="# >>> nocoder windowrules begin" MARK_END="# <<< nocoder windowrules end" diff --git a/uninstall.sh b/uninstall.sh index f4518c7..aad5021 100755 --- a/uninstall.sh +++ b/uninstall.sh @@ -12,7 +12,7 @@ DESKTOP_DIR="$HOME/.local/share/applications" HICOLOR_DIR="$HOME/.local/share/icons/hicolor" INSTALL_DIR="$HOME/.local/share/nocoder" CONFIG_DIR="${XDG_CONFIG_HOME:-$HOME/.config}/nocoder" -HYPR_CONF="$HOME/.config/hypr/windows.conf" +HYPR_CONF="$HOME/.config/hypr/hyprland.conf" MARK_BEGIN="# >>> nocoder windowrules begin" MARK_END="# <<< nocoder windowrules end"