nosignal/nosignal-shell
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix: lint format script incorrectly popping scope

Browse source
This commit is contained in:
2 * r + 2 * t 2026-03-21 15:21:50 +11:00
parent 5912d54991
commit 3e52aa5fb3
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
scripts/qml-lint-conventions.py
View file

@ -9,7 +9,8 @@ Required ordering within each QML object (with blank line between sections):
3. signal declarations 3. signal declarations
4. JavaScript functions 4. JavaScript functions
5. object properties (bindings) 5. object properties (bindings)
6. child objects / component definitions 6. child objects
7. component definitions
""" """
import re import re
@ -184,7 +185,8 @@ def check_file(filepath: Path) -> list[Violation]:
func_skip_depth = 0 func_skip_depth = 0
continue continue
# Closing brace: pop scope for this indent and all deeper scopes # Closing brace: pop all scopes deeper than this indent
# (the scope at this indent belongs to the parent object and must persist)
if stripped == "}": if stripped == "}":
# Check: blank line right before closing brace # Check: blank line right before closing brace
if i > 0 and not lines[i - 1].strip(): if i > 0 and not lines[i - 1].strip():
@ -196,8 +198,6 @@ def check_file(filepath: Path) -> list[Violation]:
"no blank line expected before closing brace", "no blank line expected before closing brace",
) )
) )
scopes.pop(indent, None)
prev_blank.pop(indent, None)
to_remove = [k for k in scopes if len(k) > len(indent)] to_remove = [k for k in scopes if len(k) > len(indent)]
for k in to_remove: for k in to_remove:
del scopes[k] del scopes[k]