nosignal/nosignal-shell
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

chore: format QML lint script

Browse source
This commit is contained in:
2 * r + 2 * t 2026-03-20 23:46:52 +11:00
parent f5440eb190
commit 5912d54991
1 changed files with 39 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

61
scripts/qml-lint-conventions.py
View file

@ -56,9 +56,7 @@ RULE_COLOURS = {
}
# Regexes
PROPERTY_DECL_RE = re.compile(
r"^(?:required\s+|readonly\s+|default\s+)*property\s"
)
PROPERTY_DECL_RE = re.compile(r"^(?:required\s+|readonly\s+|default\s+)*property\s")
SIGNAL_RE = re.compile(r"^signal\s")
FUNCTION_RE = re.compile(r"^function\s")
ID_RE = re.compile(r"^id\s*:\s*[a-zA-Z_]\w*\s*$")
@ -162,12 +160,15 @@ def check_file(filepath: Path) -> list[Violation]:
# Track blank lines per indent
if not stripped:
# Check: blank line right after opening brace of a QML object
if (i > 0 and func_skip_depth == 0 and not in_block_comment
and lines[i - 1].strip().endswith("{")):
violations.append(Violation(
rel, lineno, "blank-after-open-brace",
if i > 0 and func_skip_depth == 0 and not in_block_comment and lines[i - 1].strip().endswith("{"):
violations.append(
Violation(
rel,
lineno,
"blank-after-open-brace",
"no blank line expected after opening brace",
))
)
)
for key in prev_blank:
prev_blank[key] = True
continue
@ -187,10 +188,14 @@ def check_file(filepath: Path) -> list[Violation]:
if stripped == "}":
# Check: blank line right before closing brace
if i > 0 and not lines[i - 1].strip():
violations.append(Violation(
rel, lineno, "blank-before-close-brace",
violations.append(
Violation(
rel,
lineno,
"blank-before-close-brace",
"no blank line expected before closing brace",
))
)
)
scopes.pop(indent, None)
prev_blank.pop(indent, None)
to_remove = [k for k in scopes if len(k) > len(indent)]
@ -213,22 +218,27 @@ def check_file(filepath: Path) -> list[Violation]:
# --- Check 1: Section ordering ---
if tracker.last_section is not None and section < tracker.last_section:
violations.append(Violation(
rel, lineno, "section-order",
violations.append(
Violation(
rel,
lineno,
"section-order",
f"{SECTION_NAMES[section]} should appear before "
f"{SECTION_NAMES[tracker.last_section]} "
f"(seen at line {tracker.last_section_line})",
))
)
)
# --- Check 2: Missing blank line between different sections ---
if (tracker.last_section is not None
and section != tracker.last_section
and not had_blank):
violations.append(Violation(
rel, lineno, "missing-section-separator",
f"blank line expected between {SECTION_NAMES[tracker.last_section]} "
f"and {SECTION_NAMES[section]}",
))
if tracker.last_section is not None and section != tracker.last_section and not had_blank:
violations.append(
Violation(
rel,
lineno,
"missing-section-separator",
f"blank line expected between {SECTION_NAMES[tracker.last_section]} and {SECTION_NAMES[section]}",
)
)
# Update tracker
if tracker.last_section is None or section >= tracker.last_section:
@ -246,7 +256,7 @@ def check_file(filepath: Path) -> list[Violation]:
# and expression blocks like `color: { ... }`)
if brace_count > 0 and section == Section.BINDING:
colon_idx = stripped.index(":")
after_colon = stripped[colon_idx + 1:].strip()
after_colon = stripped[colon_idx + 1 :].strip()
# If content after : doesn't start with an uppercase type name,
# it's a JS block (not an inline QML object like `contentItem: Rect {`)
if not re.match(r"^[A-Z]", after_colon):
@ -263,10 +273,7 @@ def check_file(filepath: Path) -> list[Violation]:
def main():
qml_files = sorted(
p for p in REPO_ROOT.rglob("*.qml")
if "build" not in p.parts
)
qml_files = sorted(p for p in REPO_ROOT.rglob("*.qml") if "build" not in p.parts)
print(f"{BOLD}Checking {len(qml_files)} QML files for convention violations...{RESET}\n")