nosignal/nosignal-shell
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

controlcenter: corrected wallpaper flicker issue

Browse source
This commit is contained in:
ATMDA 2025-11-15 17:07:27 -05:00
parent b0006f2f11
commit 7023a72ef1
3 changed files with 42 additions and 39 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

79
modules/controlcenter/appearance/AppearancePane.qml
View file

@ -1049,10 +1049,10 @@ RowLayout {
Layout.preferredHeight: 140 Layout.preferredHeight: 140
Layout.minimumWidth: 200 Layout.minimumWidth: 200
Layout.minimumHeight: 140 Layout.minimumHeight: 140
Layout.maximumWidth: 200
Layout.maximumHeight: 140
readonly property bool isCurrent: modelData.path === Wallpapers.actualCurrent readonly property bool isCurrent: modelData.path === Wallpapers.actualCurrent
readonly property real imageWidth: Math.max(1, width)
readonly property real imageHeight: Math.max(1, height)
StateLayer { StateLayer {
radius: Appearance.rounding.normal radius: Appearance.rounding.normal
@ -1069,71 +1069,72 @@ RowLayout {
color: Colours.tPalette.m3surfaceContainer color: Colours.tPalette.m3surfaceContainer
radius: Appearance.rounding.normal radius: Appearance.rounding.normal
border.width: isCurrent ? 2 : 0
border.color: Colours.palette.m3primary
CachingImage { CachingImage {
id: cachingImage id: cachingImage
path: modelData.path path: modelData.path
anchors.fill: parent anchors.fill: parent
cache: true
visible: opacity > 0
// Ensure sourceSize is always set to valid dimensions // Show when ready
sourceSize: Qt.size(Math.max(1, Math.floor(parent.width)), Math.max(1, Math.floor(parent.height))) opacity: status === Image.Ready ? 1 : 0
// Show when ready, hide if fallback is showing
opacity: status === Image.Ready && !fallbackImage.visible ? 1 : 0
Behavior on opacity { Behavior on opacity {
NumberAnimation { NumberAnimation {
duration: 200 duration: 150
easing.type: Easing.OutQuad
} }
} }
} }
// Fallback: Direct image load if caching fails or is slow // Fallback image for when caching fails
Image { Image {
id: fallbackImage id: fallbackImage
anchors.fill: parent anchors.fill: parent
source: modelData.path source: fallbackTimer.triggered && cachingImage.status !== Image.Ready ? modelData.path : ""
asynchronous: true asynchronous: true
fillMode: Image.PreserveAspectCrop fillMode: Image.PreserveAspectCrop
sourceSize: Qt.size(Math.max(1, Math.floor(parent.width)), Math.max(1, Math.floor(parent.height))) cache: true
// Show if caching image hasn't loaded after a delay
visible: opacity > 0 visible: opacity > 0
opacity: 0
Timer { opacity: status === Image.Ready && cachingImage.status !== Image.Ready ? 1 : 0
id: fallbackTimer
interval: 500
running: cachingImage.status === Image.Loading || (cachingImage.status !== Image.Ready && cachingImage.status !== Image.Null)
onTriggered: {
if (cachingImage.status !== Image.Ready && fallbackImage.status === Image.Ready) {
fallbackImage.opacity = 1;
}
}
}
// Also check status changes
onStatusChanged: {
if (status === Image.Ready && cachingImage.status !== Image.Ready) {
Qt.callLater(() => {
if (cachingImage.status !== Image.Ready) {
fallbackImage.opacity = 1;
}
});
}
}
Behavior on opacity { Behavior on opacity {
NumberAnimation { NumberAnimation {
duration: 200 duration: 150
easing.type: Easing.OutQuad
} }
} }
} }
// Timer to trigger fallback only if caching hasn't loaded
Timer {
id: fallbackTimer
property bool triggered: false
interval: 800
running: cachingImage.status === Image.Loading || cachingImage.status === Image.Null
onTriggered: triggered = true
}
}
// Border overlay that doesn't affect image size
Rectangle {
anchors.fill: parent
color: "transparent"
radius: Appearance.rounding.normal
border.width: isCurrent ? 2 : 0
border.color: Colours.palette.m3primary
Behavior on border.width {
NumberAnimation {
duration: 150
easing.type: Easing.OutQuad
}
}
MaterialIcon { MaterialIcon {
anchors.right: parent.right anchors.right: parent.right
anchors.top: parent.top anchors.top: parent.top

1
modules/launcher/items/WallpaperItem.qml
View file

@ -67,6 +67,7 @@ Item {
CachingImage { CachingImage {
path: root.modelData.path path: root.modelData.path
smooth: !root.PathView.view.moving smooth: !root.PathView.view.moving
cache: true
anchors.fill: parent anchors.fill: parent
} }

1
shell Submodule

@ -0,0 +1 @@
Subproject commit 442b49e0e1975d51efcef90d10566c90dedbf7e1