nosignal/nosignal-shell
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

nmcli: use Map-based lookups for network deduplication

Browse source 
Replace O(n²) nested .filter()/.find() loops with Map-keyed
lookups for both removal and update passes in getNetworks().
This commit is contained in:
2 * r + 2 * t 2026-03-12 21:51:44 +11:00
parent 11f5a2ee45
commit 9464c72f7a
1 changed files with 16 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
services/Nmcli.qml
View file

@ -751,17 +751,25 @@ Singleton {
const networks = deduplicateNetworks(allNetworks);
const rNetworks = root.networks;
const destroyed = rNetworks.filter(rn => !networks.find(n => n.frequency === rn.frequency && n.ssid === rn.ssid && n.bssid === rn.bssid));
for (const network of destroyed) {
const index = rNetworks.indexOf(network);
if (index >= 0) {
rNetworks.splice(index, 1);
network.destroy();
const newMap = new Map();
for (const n of networks)
newMap.set(`${n.frequency}:${n.ssid}:${n.bssid}`, n);
for (let i = rNetworks.length - 1; i >= 0; i--) {
const rn = rNetworks[i];
const key = `${rn.frequency}:${rn.ssid}:${rn.bssid}`;
if (!newMap.has(key)) {
rNetworks.splice(i, 1);
rn.destroy();
}
}
for (const network of networks) {
const match = rNetworks.find(n => n.frequency === network.frequency && n.ssid === network.ssid && n.bssid === network.bssid);
const existingMap = new Map();
for (const rn of rNetworks)
existingMap.set(`${rn.frequency}:${rn.ssid}:${rn.bssid}`, rn);
for (const [key, network] of newMap) {
const match = existingMap.get(key);
if (match) {
match.lastIpcObject = network;
} else {