From 9b1b33a3883ea362ae46a7cfe697d18f574492cf Mon Sep 17 00:00:00 2001 From: 2 * r + 2 * t <61896496+soramanew@users.noreply.github.com> Date: Sun, 12 Apr 2026 01:19:48 +1000 Subject: [PATCH] feat: remove file prefix on signals --- plugin/src/Caelestia/Config/configobject.cpp | 11 ++++++----- plugin/src/Caelestia/Config/configobject.hpp | 8 ++++---- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/plugin/src/Caelestia/Config/configobject.cpp b/plugin/src/Caelestia/Config/configobject.cpp index 7a36f7b5..00769941 100644 --- a/plugin/src/Caelestia/Config/configobject.cpp +++ b/plugin/src/Caelestia/Config/configobject.cpp @@ -268,14 +268,15 @@ void ConfigObject::setupFileBackend(const QString& path) { if (!file.open(QIODevice::WriteOnly)) { qCWarning(lcConfig, "Failed to write %s", qUtf8Printable(m_filePath)); if (auto* root = qobject_cast(this)) - emit root->fileSaveFailed(QStringLiteral("Failed to open file for writing")); + emit root->saveFailed(QStringLiteral("Failed to open file for writing")); return; } auto json = toJsonObject(); file.write(QJsonDocument(json).toJson(QJsonDocument::Indented)); + file.close(); if (auto* root = qobject_cast(this)) - emit root->fileSaved(); + emit root->saved(); }); m_cooldownTimer->setSingleShot(true); @@ -355,9 +356,9 @@ void ConfigObject::onFileChanged() { bool ok = reloadFromFile(); if (auto* root = qobject_cast(this)) { if (ok) - emit root->fileLoaded(); + emit root->loaded(); else - emit root->fileLoadFailed(QStringLiteral("Failed to load config file")); + emit root->loadFailed(QStringLiteral("Failed to load config file")); } } } @@ -373,7 +374,7 @@ void RootConfig::save() { void RootConfig::reload() { if (reloadFromFile()) - emit fileLoaded(); + emit loaded(); } } // namespace caelestia::config diff --git a/plugin/src/Caelestia/Config/configobject.hpp b/plugin/src/Caelestia/Config/configobject.hpp index 8ffe074c..66df4ac3 100644 --- a/plugin/src/Caelestia/Config/configobject.hpp +++ b/plugin/src/Caelestia/Config/configobject.hpp @@ -126,10 +126,10 @@ public: Q_INVOKABLE void reload(); signals: - void fileLoaded(); - void fileLoadFailed(const QString& error); - void fileSaved(); - void fileSaveFailed(const QString& error); + void loaded(); + void loadFailed(const QString& error); + void saved(); + void saveFailed(const QString& error); }; } // namespace caelestia::config