From b85b0e7afb90fcf333969f8c41bd6b9f26202ab7 Mon Sep 17 00:00:00 2001
From: 2 * r + 2 * t <61896496+soramanew@users.noreply.github.com>
Date: Tue, 24 Mar 2026 01:52:25 +1100
Subject: [PATCH] fix: use QPointer for ImageAnalyser::m_sourceItem

Raw QQuickItem* was not tracked for destruction, causing
use-after-free if the source item was destroyed between
setSourceItem() and deferred requestUpdate() invocations.
---
 plugin/src/Caelestia/imageanalyser.hpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/plugin/src/Caelestia/imageanalyser.hpp b/plugin/src/Caelestia/imageanalyser.hpp
index bbea2b32..63fbf969 100644
--- a/plugin/src/Caelestia/imageanalyser.hpp
+++ b/plugin/src/Caelestia/imageanalyser.hpp
@@ -4,6 +4,7 @@
 #include <qfuture.h>
 #include <qfuturewatcher.h>
 #include <qobject.h>
+#include <qpointer.h>
 #include <qqmlintegration.h>
 
 namespace caelestia {
@@ -48,7 +49,7 @@ private:
     QFutureWatcher<AnalyseResult>* const m_futureWatcher;
 
     QString m_source;
-    QQuickItem* m_sourceItem;
+    QPointer<QQuickItem> m_sourceItem;
     int m_rescaleSize;
 
     QColor m_dominantColour;