From ba2d4f03d6151c922e75521953051015d8e36eac Mon Sep 17 00:00:00 2001
From: 2 * r + 2 * t <61896496+soramanew@users.noreply.github.com>
Date: Fri, 8 May 2026 02:49:28 +1000
Subject: [PATCH] fix: dash media lyrics overlapping

Apparently Behavior on model is a bad idea...
---
 modules/dashboard/media/LyricList.qml | 39 ++++++++++++++-------------
 1 file changed, 20 insertions(+), 19 deletions(-)

diff --git a/modules/dashboard/media/LyricList.qml b/modules/dashboard/media/LyricList.qml
index 2bae5ee7..0d44293c 100644
--- a/modules/dashboard/media/LyricList.qml
+++ b/modules/dashboard/media/LyricList.qml
@@ -25,6 +25,7 @@ Item {
 
     readonly property real fadeAmount: 0.1
     property bool flag
+    property list<string> lyricList: Lyrics.lyrics
 
     layer.enabled: true
     layer.effect: Mask {
@@ -236,7 +237,7 @@ Item {
         displayMarginBeginning: anchors.topMargin
         displayMarginEnd: anchors.bottomMargin
 
-        model: Lyrics.lyrics
+        model: root.lyricList
         Component.onCompleted: {
             currentIndex = Qt.binding(() => {
                 model; // Force update when lyrics change
@@ -285,28 +286,28 @@ Item {
             }
         }
 
-        Behavior on model {
-            SequentialAnimation {
-                Anim {
-                    target: lyrics
-                    property: "opacity"
-                    to: 0
-                    type: Anim.DefaultEffects
-                }
-                PropertyAction {}
-                Anim {
-                    target: lyrics
-                    property: "opacity"
-                    to: 1
-                    type: Anim.SlowEffects
-                }
-            }
-        }
-
         Behavior on opacity {
             Anim {
                 type: Anim.SlowEffects
             }
         }
     }
+
+    Behavior on lyricList {
+        SequentialAnimation {
+            Anim {
+                target: lyrics
+                property: "opacity"
+                to: 0
+                type: Anim.DefaultEffects
+            }
+            PropertyAction {}
+            Anim {
+                target: lyrics
+                property: "opacity"
+                to: 1
+                type: Anim.SlowEffects
+            }
+        }
+    }
 }