nosignal/nosignal-shell
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix: remove newline-after-id rule in custom linter

Browse source
This commit is contained in:
2 * r + 2 * t 2026-03-20 23:46:38 +11:00
parent c3fd5aa905
commit f5440eb190
1 changed files with 2 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
scripts/qml-lint-conventions.py
View file

@ -49,7 +49,6 @@ SECTION_NAMES = {
} }
RULE_COLOURS = { RULE_COLOURS = {
"missing-blank-after-id": RED,
"section-order": YELLOW, "section-order": YELLOW,
"missing-section-separator": CYAN, "missing-section-separator": CYAN,
"blank-after-open-brace": MAGENTA, "blank-after-open-brace": MAGENTA,
@ -212,17 +211,7 @@ def check_file(filepath: Path) -> list[Violation]:
tracker = scopes[indent] tracker = scopes[indent]
had_blank = prev_blank.get(indent, True) had_blank = prev_blank.get(indent, True)
# --- Check 1: Missing blank line after id --- # --- Check 1: Section ordering ---
if section == Section.ID:
if i + 1 < len(lines):
next_stripped = lines[i + 1].strip()
if next_stripped and next_stripped != "}":
violations.append(Violation(
rel, lineno, "missing-blank-after-id",
"id should be followed by a blank line",
))
# --- Check 2: Section ordering ---
if tracker.last_section is not None and section < tracker.last_section: if tracker.last_section is not None and section < tracker.last_section:
violations.append(Violation( violations.append(Violation(
rel, lineno, "section-order", rel, lineno, "section-order",
@ -231,7 +220,7 @@ def check_file(filepath: Path) -> list[Violation]:
f"(seen at line {tracker.last_section_line})", f"(seen at line {tracker.last_section_line})",
)) ))
# --- Check 3: Missing blank line between different sections --- # --- Check 2: Missing blank line between different sections ---
if (tracker.last_section is not None if (tracker.last_section is not None
and section != tracker.last_section and section != tracker.last_section
and not had_blank): and not had_blank):