nosignal/nosignal-shell
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix: use QPointer for ImageAnalyser::m_sourceItem

Browse source 
Raw QQuickItem* was not tracked for destruction, causing
use-after-free if the source item was destroyed between
setSourceItem() and deferred requestUpdate() invocations.
This commit is contained in:
2 * r + 2 * t 2026-03-24 01:52:25 +11:00
parent 04b4ae3ba8
commit b85b0e7afb
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
plugin/src/Caelestia/imageanalyser.hpp
View file

@ -4,6 +4,7 @@
#include <qfuture.h> #include <qfuture.h>
#include <qfuturewatcher.h> #include <qfuturewatcher.h>
#include <qobject.h> #include <qobject.h>
#include <qpointer.h>
#include <qqmlintegration.h> #include <qqmlintegration.h>
namespace caelestia { namespace caelestia {
@ -48,7 +49,7 @@ private:
QFutureWatcher<AnalyseResult>* const m_futureWatcher; QFutureWatcher<AnalyseResult>* const m_futureWatcher;
QString m_source; QString m_source;
QQuickItem* m_sourceItem; QPointer<QQuickItem> m_sourceItem;
int m_rescaleSize; int m_rescaleSize;
QColor m_dominantColour; QColor m_dominantColour;